e2e/journey-app/main.ts (2)

44-54: Same optional chaining inconsistency.

Line 48 uses req.headers.append() without optional chaining while line 49 uses req.headers?.set(). Apply the same consistency fix here.

♻️ Proposed fix

       case 'JOURNEY_TERMINATE':
         req.url.searchParams.set('end-session-middleware', 'end-session');
         req.headers.append('x-end-session-middleware', 'end-session');
-        req.headers?.set('Accept-Language', 'zz-ZZ');
+        req.headers.set('Accept-Language', 'zz-ZZ');
         break;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@e2e/journey-app/main.ts` around lines 44 - 54, The middleware handling the
'JOURNEY_TERMINATE' action mixes direct and optional-chained header access
(req.headers.append(...) vs req.headers?.set(...)); make them consistent by
using the same presence-guard approach for headers in that switch case — update
the block handling 'JOURNEY_TERMINATE' to call the same method access style
(either both optional-chained or both direct) on req.headers (e.g., change
req.headers.append to req.headers?.append or change req.headers?.set to
req.headers.set) so both header manipulations use the identical pattern.

---

29-42: Inconsistent optional chaining on req.headers.

Lines 32-33 and 37-38 use req.headers.append() without optional chaining, while lines 34 and 39 use req.headers?.set() with optional chaining. This inconsistency suggests either the optional chaining is unnecessary or the non-optional calls could fail if headers were ever undefined.

♻️ Proposed fix for consistency

       case 'JOURNEY_START':
         req.url.searchParams.set('start-authenticate-middleware', 'start-authentication');
         req.headers.append('x-start-authenticate-middleware', 'start-authentication');
-        req.headers?.set('Accept-Language', 'xx-XX');
+        req.headers.set('Accept-Language', 'xx-XX');
         break;
       case 'JOURNEY_NEXT':
         req.url.searchParams.set('authenticate-middleware', 'authentication');
         req.headers.append('x-authenticate-middleware', 'authentication');
-        req.headers?.set('Accept-Language', 'yy-YY');
+        req.headers.set('Accept-Language', 'yy-YY');
         break;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@e2e/journey-app/main.ts` around lines 29 - 42, The code inconsistently uses
optional chaining on req.headers (mixing req.headers.append(...) and
req.headers?.set(...)) inside the middleware handling action.type
'JOURNEY_START' and 'JOURNEY_NEXT'; make it consistent by treating req.headers
as non-null (remove the ?. calls) or defensively guarding all header operations
with optional chaining or a null check. Update the four header operations
(setting 'x-start-authenticate-middleware', 'x-authenticate-middleware', and
'Accept-Language') so they all use the same approach (either
req.headers.append(...) / req.headers.set(...) everywhere or check if
req.headers before calling append/set) to prevent runtime errors and keep
behavior predictable.

e2e/journey-suites/src/request-middleware.test.ts (1)

68-75: Redundant assertions for Accept-Language.

Lines 69-71 checking .not.toContain('en-US') are redundant since lines 73-75 assert the exact expected values. If xx-XX, yy-YY, and zz-ZZ are correct, they inherently don't contain en-US.

Consider removing lines 69-71 to reduce test verbosity.

♻️ Proposed simplification

   // Check that Accept-Language header was modified from default en-US locale and set to correct value in each middleware
-  expect(startHeader?.get('Accept-Language')).not.toContain('en-US');
-  expect(nextHeader?.get('Accept-Language')).not.toContain('en-US');
-  expect(endHeader?.get('Accept-Language')).not.toContain('en-US');
-
   expect(startHeader?.get('Accept-Language')).toBe('xx-XX');
   expect(nextHeader?.get('Accept-Language')).toBe('yy-YY');
   expect(endHeader?.get('Accept-Language')).toBe('zz-ZZ');

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@e2e/journey-suites/src/request-middleware.test.ts` around lines 68 - 75,
Remove the redundant "not.toContain('en-US')" assertions for Accept-Language by
deleting the three checks that reference startHeader?.get('Accept-Language'),
nextHeader?.get('Accept-Language'), and endHeader?.get('Accept-Language') which
assert they do not contain 'en-US'; keep the existing exact-value assertions
that expect 'xx-XX', 'yy-YY', and 'zz-ZZ' respectively so the test remains
concise and still validates the header transformations.

Configuration used: defaults

Review profile: CHILL

Plan: Pro